bug: project fails to build on Windows

[mdellanave]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Stencil Version

4.16

Stencil Framework Output Target

Angular

Stencil Framework Output Target Version

0.8.4

Current Behavior

running pnpm build fails due to this error

Expected Behavior

should pass the tests and creates all the libraries

Steps to Reproduce

download the main branch and follow the instructions in readme file

Code Reproduction URL

https://github.com/ionic-team/stencil-ds-output-targets

Additional Information

No response

[ionitron-bot]

Thanks for the issue!

This project is currently maintained for the purposes of supporting Ionic Framework. At this time, only new issues & pull requests that support Ionic Framework will be prioritized. For the latest updates regarding the maintenance status of this project, please see this section of the project's README

[sean-perkins]

I do not believe the README includes instructions for running the tests, only installing and building the projects in the workspace.

The screenshot indicates the diffs are caused by code formatting. The component wrappers are generated with a static formatting output and then are expected to be formatted by the developers configuration (prettier, etc.).

Can you try running prettier and then see if the tests pass on your end?

npm run prettier from the root of the workspace should format all projects.

[mdellanave]

Thank you @sean-perkins for your time

I don't see problem in npm run prettier

it's the pnpm build that cause the error I mentioned in the topic, I think because it fails to run the tests parts on angular.

Do you need some more info?

[christian-bromann]

I wonder if this is related to the fact that Windows is being used here. Our pipeline as well as most of machines our devs run are Linux based (most folks use Macs).

[sean-perkins]

Yeah I think it has to be a character encoding difference between Windows and Unix systems. I didn't include it in my original comment, but the --write flag should be passed to prettier:

pnpm run prettier -- --write

However I was unable to get the tests to fail with:

• pnpm install
• pnpm run build
• pnpm run test

as well as they are passing in CI.

With our maintenance status, we are unlikely to prioritize investigation into this issue. We'd gladly welcome a contribution if you are able to root cause the issue.

[ionitron-bot]

This issue has been labeled as help wanted. This label is added to issues that we believe would be good for contributors.

If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.
Thank you!

[mdellanave]

if I run pnpm run prettier --write (or pnpm run prettier -- --write as @sean-perkins wrote)

Which version of pnpm are you using guys?