Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ionic-core and ionicons use different stencil versions which results in bundle warning #29896

Open
3 tasks done
muuvmuuv opened this issue Sep 26, 2024 · 0 comments
Open
3 tasks done
Labels

Comments

@muuvmuuv
Copy link

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

When building a Angular app using application bundler with esbuild I get the following warning, because ionic-core and ionicons use different stencil-core versions.

The import path @stencil/core/internal/app-data resolves to multiple files in the bundle:
[node_modules/.pnpm/@[email protected]/node_modules/@stencil/core/internal/app-data/index.js](javascript:void 0)
[node_modules/.pnpm/@[email protected]/node_modules/@stencil/core/internal/app-data/index.js](javascript:void 0)
The import path @stencil/core/internal/client resolves to multiple files in the bundle:
[node_modules/.pnpm/@[email protected]/node_modules/@stencil/core/internal/client/index.js](javascript:void 0)
[node_modules/.pnpm/@[email protected]/node_modules/@stencil/core/internal/client/index.js](javascript:void 0)
dependencies:
@ionic/angular 8.3.1
├─┬ @ionic/core 8.3.1
│ ├── @stencil/core 4.20.0
│ └─┬ ionicons 7.4.0
│   └── @stencil/core 4.21.0
└─┬ ionicons 7.4.0
  └── @stencil/core 4.21.0
@ionic/core 8.3.1
├── @stencil/core 4.20.0
└─┬ ionicons 7.4.0
  └── @stencil/core 4.21.0
ionicons 7.4.0
└── @stencil/core 4.21.0

Expected Behavior

Since both are used together it would make sense they always use the same stencil versions.

Steps to Reproduce

Install ionic and ionicons with versions above.

Code Reproduction URL

Not required imo

Ionic Info

Ionic:

Ionic CLI : 7.2.0 (/Users/marvin/.bun/install/global/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 8.3.1
@angular-devkit/build-angular : 18.2.6
@angular-devkit/schematics : 18.2.6
@angular/cli : 18.2.6
@ionic/angular-toolkit : not installed

Capacitor:

Capacitor CLI : 6.1.2
@capacitor/android : 6.1.2
@capacitor/core : 6.1.2
@capacitor/ios : 6.1.2

Utility:

cordova-res : not installed globally
native-run : not installed globally

System:

NodeJS : v22.7.0 (/opt/homebrew/Cellar/node/22.7.0/bin/node)
npm : 10.8.2
OS : macOS Unknown

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant