Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove serilog dependencies #315

Open
smasherprog opened this issue Jul 6, 2023 · 11 comments
Open

Please remove serilog dependencies #315

smasherprog opened this issue Jul 6, 2023 · 11 comments

Comments

@smasherprog
Copy link

We have been bitten by this again in a recent release. This logging library should NOT be a dependency in your nuget package.

@smasherprog
Copy link
Author

smasherprog commented Jul 6, 2023

We are currently going into a freeze on updates to quickbooks library due to issues with serilog.

Server Error in '/' Application.
Method not found: 'Serilog.LoggerConfiguration Serilog.FileLoggerConfigurationExtensions.File(Serilog.Configuration.LoggerSinkConfiguration, System.String, Serilog.Events.LogEventLevel, System.String, System.IFormatProvider, System.Nullable1<Int64>, Serilog.Core.LoggingLevelSwitch, Boolean, Boolean, System.Nullable1<System.TimeSpan>, Serilog.RollingInterval, Boolean, System.Nullable`1, System.Text.Encoding, Serilog.Sinks.File.FileLifecycleHooks)'.

@smasherprog
Copy link
Author

Quickbooks is not adding version ranges to their nuget package for their dependencies. This has been going on for years now?

@redhorseck
Copy link

Yes. Years.

@eswann
Copy link

eswann commented Aug 17, 2023

I don't understand why they took a hard dependency on Serilog (and a specific version at that). This is exactly why libraries should code against the M$ ILogger interface, even if it's less ideal than using Serilog directly. This has us unable to upgrade the SDK and we can't pin our version of Serilog to what they are using.

@clement911
Copy link
Contributor

Depending on your needs, you might want to consider using the community .NET SDK QuickBooksSharp. It has a much lighter footprint and a more modern API up to date with latest .NET practices. Disclaimer: I maintain this library.

@redhorseck
Copy link

Thanks I will check it out again. I had look at it but the last update was 9 months ago so I wasn't sure if it was still being maintained. Good to hear that it is.

@eswann
Copy link

eswann commented Aug 18, 2023

@clement911 I would check it out, but for us there is already a lot of code using the existing SDK, and don't have the time (or permission) to rewrite all of it to use a different library.

@attahameed
Copy link

Is there any update on the request. It stopping us from using the latest version.

@drusellers
Copy link

Why is this library using Serilog rather than Microsoft Extensions Logging? If NOTHING else, this should be an optional dependency.

@xosevilla
Copy link

Still not fixed. What version of this 'Serilog.Sinks.File' dll is expected?

@CyanideMonkey
Copy link

I had some hope that with 14.6.3.7 dropping recently that we might be able to update Serilog.Sinks.Seq with it, but still stuck 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants