Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version range for Serilog dependencies #258

Open
nbarbettini opened this issue Sep 15, 2022 · 1 comment
Open

Use version range for Serilog dependencies #258

nbarbettini opened this issue Sep 15, 2022 · 1 comment

Comments

@nbarbettini
Copy link

nbarbettini commented Sep 15, 2022

I've been bitten twice by this: #225 (comment)
I agree with the suggestion in #221 that removing references to Serilog entirely is a good direction for a library project to take.

In the meantime, some of the developer pain could be avoided by declaring a version range in the Nuget package.

Instead of

<PackageReference Include = "Serilog.Sinks.Console" Version="3.1.1" /> <!-- Supports any version 3.1.1 or higher -->

I suggest

<PackageReference Include = "Serilog.Sinks.Console" Version="[3.1.*,4)" /> <!-- Supports 3.1.0 or higher, but not 4.x -->
@nbarbettini nbarbettini changed the title Use version range for Serilog dependency Use version range for Serilog dependencies Sep 15, 2022
@smasherprog
Copy link

Having all of the serilog references is such a poor design choice. please correct this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants