Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open (old finished result) in API will result in bad-request to API #450

Open
bwbroersma opened this issue Jun 12, 2023 · 2 comments
Open
Labels
waiting Waiting for a third party to respond, or fix getting pushed.

Comments

@bwbroersma
Copy link
Collaborator

Open (old finished result) in API will result in bad-request to API.

I think if an API request to internet.nl reaches the state finished in the dashboard, it's no longer fetched / updated? However the generated report on the (batch) API can expire, and pthis will result in linking to /request/{guid}/results](https://github.com/internetstandards/Internet.nl-dashboard-frontend/blob/18104a43e6cf67aad559e46e0f33b0d6b98a6839/src/components/scans/ScanMonitorScan.vue#L129) while there no longer is a report, resulting in the browser returning this on the initial request:

{"error": {"label": "bad-request", "msg": "The request is not yet `done`."}, "api_version": "2.3.0"}
@bwbroersma bwbroersma added the waiting Waiting for a third party to respond, or fix getting pushed. label Jul 11, 2023
@stitch
Copy link
Collaborator

stitch commented Mar 4, 2024

Several options available:

  • Should the old API response as stored in the dashboard be browsed instead?
  • Should old API responses just never be cleaned up?
  • Or, the easiest, a direct link be removed in the GUI after a while?

@bwbroersma
Copy link
Collaborator Author

I added waiting since I think this should be fixed in the API code. It's not a priority issue. I do think it's nice it links to the API (some people might use save-link-as, there is no monitoring on that, so we don't know if it's used, although 'probably' it's not used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Waiting for a third party to respond, or fix getting pushed.
Development

No branches or pull requests

2 participants