Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WM ext browser support - Edge #67

Closed
tselit opened this issue Dec 20, 2023 · 8 comments · Fixed by #608
Closed

WM ext browser support - Edge #67

tselit opened this issue Dec 20, 2023 · 8 comments · Fixed by #608
Assignees

Comments

@tselit
Copy link

tselit commented Dec 20, 2023

Context

WM extension compatibility with the Microsoft Edge browser.

Todos

TBC

@tselit tselit added the enhancement New feature or request label Dec 20, 2023
@tselit
Copy link
Author

tselit commented Jun 19, 2024

Bibi to do: test on Edge and then should be ready to close

@RabebOthmani RabebOthmani added this to the WM Backlog milestone Jun 20, 2024
@sidvishnoi
Copy link
Member

To test: How it works in split-window mode (#366 (comment))

@raducristianpopa
Copy link
Member

In split view, the extension is only taking into the consideration only the first pane from the split view when updating icon. If we are on a non-monetized website in the first pane and on a web monetized one in the second one, the icon will have the non-monetized website identifier.

image

@raducristianpopa
Copy link
Member

raducristianpopa commented Aug 21, 2024

Arc's split view should be checked as well.
Vivaldi's tab tiling as well.

@raducristianpopa raducristianpopa removed this from the WM Backlog milestone Aug 21, 2024
@RabebOthmani RabebOthmani removed the enhancement New feature or request label Aug 28, 2024
@RabebOthmani
Copy link
Collaborator

Blocked as we wait for the MS support team

@sidvishnoi
Copy link
Member

sidvishnoi commented Sep 12, 2024

@sidvishnoi
Copy link
Member

sidvishnoi commented Sep 12, 2024

Found the sender port in Runtime.Port message handler returns correct tab ID 🎉

port.onMessage.addListener((message, sendingPort) => {
   console.log(sendingPort.sender?.tab?.id);
});

So, we can make a short connection on content script inject and store tabId for use in future messages?

Edit: or instead of tabActivated event, rely on focusChange messages from content script.

@sidvishnoi
Copy link
Member

Everything works once we get right tabId, except Edge doesn't update the icon (even with correct tabId!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants