Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of Custom types #493

Closed
nakul1010 opened this issue Jul 18, 2023 · 0 comments · Fixed by #502
Closed

Remove the use of Custom types #493

nakul1010 opened this issue Jul 18, 2023 · 0 comments · Fixed by #502
Assignees
Labels
enhancement New feature or request

Comments

@nakul1010
Copy link
Member

nakul1010 commented Jul 18, 2023

Is your feature request related to a problem? Please describe.
Currently the runtime/utils contains custom implementation for AccountId and MultiSignature. This is done because scale_encode::EncodeAsType and scale_decode::DecodeAsType are not implemented for AccountId which is required for subxt version 0.29.0. But it adds an upstream dependency on subxt/utils.

Describe the solution you'd like
An ideal solution would be to use sp_core crate and wrap the custom types in Static. As Static by default implements scale_encode::EncodeAsType and scale_decode::DecodeAsType.

Additional context

  • Issue #1040 on subxt shades more light on why the specific traits are needed.
@nakul1010 nakul1010 added the enhancement New feature or request label Jul 18, 2023
@nakul1010 nakul1010 self-assigned this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant