Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qat: don't set device IDs in the plugin #1887

Open
mythi opened this issue Oct 18, 2024 · 0 comments · May be fixed by #1860
Open

qat: don't set device IDs in the plugin #1887

mythi opened this issue Oct 18, 2024 · 0 comments · May be fixed by #1860
Labels
qat QAT device plugin related issue

Comments

@mythi
Copy link
Contributor

mythi commented Oct 18, 2024

Is your feature request related to a problem? Please describe.
QAT plugin needs custom apparmor rules since it fails (on certain distros) on the attempt to write to VFIO/UIO new_id. setupDeviceIDs() is somewhat legacy since the preferred approach is driver_override.

Describe the solution you'd like
the new_id mechanism was added way before we had the initcontainer support in place. furthermore, at least for vfio-pci we don't need it at all if the driver uses ids=8086:<qat VF dev IDs>.

the suggestion is to drop write attemps to new_id and move the corresponding functionality to qat-init.sh. With this, we can drop apparmor policies from the plugin.

Describe alternatives you've considered
N/A

Additional context
N/A

@mythi mythi added the qat QAT device plugin related issue label Oct 18, 2024
@mythi mythi linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qat QAT device plugin related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant