Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve QAT+Apparmor case #1575

Closed
mythi opened this issue Oct 24, 2023 · 2 comments · Fixed by #1591
Closed

Improve QAT+Apparmor case #1575

mythi opened this issue Oct 24, 2023 · 2 comments · Fixed by #1591
Labels
docs Documentation related issue qat QAT device plugin related issue

Comments

@mythi
Copy link
Contributor

mythi commented Oct 24, 2023

Since #381, we've known that adding

 annotations:
   container.apparmor.security.beta.kubernetes.io/intel-qat-plugin: unconfined

for the QAT plugin daemonSet can be used to mitigate an issue where the plugin fails to initialize on an Apparmor enabled OS.

Triggered by #1571, I'm noticing the annotation setup is poorly documented so users are expected to run into the same problem

We have several ways to improve the case:

  • Add the annotation by default (it would be ignored on systems that don't have Apparmor but then we'd loose configurability)
  • Move dpdkDrv setup to initcontainer OR document how vfio-pci can be automatically made to probe QAT VFs (via ids module param)
  • Make the issue more visible in the docs.
  • ...
@mythi mythi added qat QAT device plugin related issue docs Documentation related issue labels Oct 24, 2023
@ozhuraki
Copy link
Contributor

ozhuraki commented Nov 3, 2023

Let's make this annotation default. If the confugurability is needed, the annotation can be dropped with the kustomization.

@mythi
Copy link
Contributor Author

mythi commented Nov 6, 2023

Let's make this annotation default. If the confugurability is needed, the annotation can be dropped with the kustomization.

I thought about making it default too but the problem is that with the operator it cannot be dropped because kustomization is not involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issue qat QAT device plugin related issue
Projects
None yet
2 participants