Add basic hooks for dask dataframe #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some things work with an awkward series in a dask-dataframe.
The hard-coded guess at a two-element array works for simple operations. I played with attaching a real form to the dtype object, but it rapidly gets complicated and towards what dask-awkward does. Which raises the question whether we should plumb in dask-awkward at least when using the accessor, and then we'll know the true dtype of any output via the typetracer. This applies even more to IO: we should use dask-awkard for reading from parquet/JSON rather than have dask.dataframe make objects that we then make back into awkward structures.
One rough edge I already found: if the operation being performed returns a different number of elements than the two supplied by the fake series, you get an error. How much do we need to push users to provide their own meta=? Can we make it for them while we have more information before passing to make_array_nonempty ?