Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: compatible with metrics 0.23 #10

Closed
MrCroxx opened this issue May 30, 2024 · 4 comments · Fixed by #11
Closed

bug: compatible with metrics 0.23 #10

MrCroxx opened this issue May 30, 2024 · 4 comments · Fixed by #11
Assignees
@tyranron
Labels
enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file semver::breaking Breaking change in terms of SemVer

Comments

@MrCroxx
Copy link

MrCroxx commented May 30, 2024 •
edited
Loading

Summary

Thank you for the great lib. I was using metrics = "0.22" with metrics-prometheus = "0.6", they worked well. But after I upgrade metrics to 0.23, all data of my metrics are gone.

Steps to reproduce

Use version 0.6 with metrics 0.23

What is the current bug behavior?

Cannot get my metrics data like with metrics 0.22

What is the expected correct behavior?

Relevant logs and/or screenshots

Possible fixes
@MrCroxx MrCroxx added the bug Something isn't working label May 30, 2024
@MrCroxx MrCroxx mentioned this issue May 30, 2024
Merged
3 tasks
@tyranron
Copy link
Member

tyranron commented May 30, 2024 •
edited
Loading

@MrCroxx yup, you cannot use it with 0.23 version of metrics, since it's a breaking change in dependencies. I'll release migration to new version shortly.

@tyranron tyranron self-assigned this May 30, 2024
@tyranron tyranron added enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file semver::breaking Breaking change in terms of SemVer and removed bug Something isn't working labels May 30, 2024
@tyranron
Copy link
Member

And yes, @dependabot is lazy bastard...

@tyranron tyranron mentioned this issue May 30, 2024
Merged
15 tasks
tyranron added a commit that referenced this issue May 30, 2024
@tyranron
Upgrade to 0.23 metrics version (#11, #10)
0feefb8 
- bump up MSRV to 1.72
@tyranron
Copy link
Member

Released as 0.7.0.
Enjoy.

@MrCroxx
Copy link
Author

MrCroxx commented May 31, 2024

Oh, thank you very much, @tyranron . That's a really fast response. 🥰

@MrCroxx MrCroxx mentioned this issue Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyranron tyranron

Labels
enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file semver::breaking Breaking change in terms of SemVer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade metrics to 0.23 version instrumentisto/metrics-prometheus-rs
2 participants
@tyranron @MrCroxx