Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Github actions reuse Makefile commands #69

Open
dusan-maksimovic opened this issue Aug 20, 2024 · 0 comments
Open

Have Github actions reuse Makefile commands #69

dusan-maksimovic opened this issue Aug 20, 2024 · 0 comments
Labels
priority: nice-to-have Features that are nice to have, but that ultimately should not block deployment.

Comments

@dusan-maksimovic
Copy link
Contributor

Currently in the rust.yml workflow we have this:

cargo test --workspace --exclude test-e2e --verbose --no-fail-fast

And in Makefile we also have this:

test-unit: cargo test --workspace --exclude test-e2e --lib --no-fail-fast

We should rewrite the workflow file to reuse Makefile commands, so we don't need to maintain the same thing in two places.
This applies to all actions, not just unit tests.

@p-offtermatt p-offtermatt added the priority: nice-to-have Features that are nice to have, but that ultimately should not block deployment. label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: nice-to-have Features that are nice to have, but that ultimately should not block deployment.
Projects
None yet
Development

No branches or pull requests

2 participants