Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example does not render _How ya doin!_ properly #1

Open
nalbion opened this issue Oct 23, 2019 · 2 comments
Open

Example does not render _How ya doin!_ properly #1

nalbion opened this issue Oct 23, 2019 · 2 comments

Comments

@nalbion
Copy link

nalbion commented Oct 23, 2019

The example does not render _How ya doin!_ properly because ! is not in _baseCharacters.

Why not use RegExp(r"_[^_]+_") for italics?

...why not use a capturing group RegExp(r"_([^_]+)_") so that you don't need postProcess?

@tiholic
Copy link
Contributor

tiholic commented Oct 23, 2019

@nalbion that sounds like a good idea 👍 Can you raise a PR with the changes?

@nalbion
Copy link
Author

nalbion commented Oct 24, 2019

I've decided to go with Zefyr as it gives a WYSIWYG editor.

I managed to come up with a single regex for bold and italics: RegExp(r'((?:\*|_){1,3})(.*?[^\1 ])\1')

https://github.com/memspace/zefyr/pull/191/files#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants