Added updated check for docs in Makefile #291
Open
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kairoaraujo PTAL !! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 82.40% 1.64% -80.76%
==========================================
Files 10 120 +110
Lines 358 28856 +28498
==========================================
+ Hits 295 476 +181
- Misses 43 28323 +28280
- Partials 20 57 +37 ☔ View full report in Codecov by Sentry. |
kairoaraujo
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Hi @DarikshaAnsari,
Thank you for your PR. 🎉
I think we should run the update_docs and the check_docs.
Note: stat -c is not a standard in all OS. Maybe we could check it using diff? 🤔
Nit: I suggest also having it to the .github/workflows for automatic checks. We can do it in another PR as well.
|
@kairoaraujo I have changed all the require changes you've mentioned also I have added checks in .github/workflow . |
|
@kairoaraujo PTAL !! |
Signed-off-by: Dariksha <[email protected]>
Signed-off-by: Dariksha <[email protected]>
Signed-off-by: Dariksha <[email protected]>
Signed-off-by: Dariksha <[email protected]>
jkjell
reviewed
Jun 6, 2024
Signed-off-by: John Kjell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180
Acceptance Criteria Met