Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible Cues when Running Comet using comet_shortcut.sh #38

Open
kevin-wijnen opened this issue Jul 14, 2024 · 0 comments
Open

Visible Cues when Running Comet using comet_shortcut.sh #38

kevin-wijnen opened this issue Jul 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kevin-wijnen
Copy link
Contributor

kevin-wijnen commented Jul 14, 2024

Is your feature request related to a problem? Please describe.
Since the transition from calling Konsole to run the script to making it fully terminal independent, the Comet logs are no more visible on their own. When using this in combination with Heroic (when attaching the script), you can only find the logs now through Heroic/Lutris (in the game's logs).

There is currently no visual indication whether a game is working with Comet (as in: Comet found an instance and is properly syncing things up), or if Comet is exiting because of a lack of a connection.

Describe the solution you'd like
I would like to either have:

  • it get a variable (similar to the DEBUG one to enable debug logs) that can enable launching it through a terminal (editable to accommodate multiple types of terminals in use)
  • it show a pop-up window when a connection can be made or when it errors out halting the script entirely
  • multiple packaged shortcut scripts to use with specific terminal (for windowed usage) or none at all (for background usage).

For the latter situation; it would be better to put the credentials elsewhere and have the scripts import it from said file, to not have to edit credentials in multiple scripts.

We know the steps for Konsole (what the Steam Deck uses) from before, and Gnome-Terminal (as found out by @italoghost here) to make separate "KDE" and "GNOME" environments.

Ideally it would be all in one script with the logic there, but I'd argue for practicality and maintenance it would be better to make multiple scripts that the user can choose what to use based on their environment.

Describe alternatives you've considered
Reusing the older comet_shortcut.sh, albeit it is no longer being hosted on the repository anymore.

@kevin-wijnen kevin-wijnen added the enhancement New feature or request label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant