From 9d770b802d16b0c284659c5ad37007d870229734 Mon Sep 17 00:00:00 2001 From: sspans-sbp <84081351+sspans-sbp@users.noreply.github.com> Date: Fri, 18 Oct 2024 14:32:20 +0200 Subject: [PATCH 1/2] Correct type in documentation --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2b57721..a5b6f36 100644 --- a/README.md +++ b/README.md @@ -92,7 +92,7 @@ The current authentication model requires providing Vault with a Gitlab Token. | base_url | yes | n/a | no | The address to access Gitlab | | auto_rotate_token | no | no | no | Should we autorotate the token when it's close to expiry? (Experimental) | | auto_rotate_before | no | 24h | no | How much time should be remaining on the token validity before we should rotate it? Minimum can be set to 24h and maximum to 730h | -| type | yes | n/a | no | The type of gitlab instance that we use can be one of saas, self-hosted or dedicated | +| type | yes | n/a | no | The type of gitlab instance that we use can be one of saas, self-managed or dedicated | ### Role From c813ced990164bf8f03ee73fd7065cd46cf3688d Mon Sep 17 00:00:00 2001 From: sspans-sbp <84081351+sspans-sbp@users.noreply.github.com> Date: Fri, 18 Oct 2024 14:34:28 +0200 Subject: [PATCH 2/2] Update descriptions in path_config.go --- path_config.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/path_config.go b/path_config.go index dd2bf71..6e3ca0d 100644 --- a/path_config.go +++ b/path_config.go @@ -33,7 +33,7 @@ var ( DisplayAttrs: &framework.DisplayAttributes{ Name: "GitLab Base URL", }, - Description: `The base URL of your GitLab instance. This could be the URL of a self-hosted GitLab instance or the URL of the GitLab SaaS service (https://gitlab.com). The URL must be properly formatted, including the scheme (http or https). This field is essential as it determines the endpoint where API requests will be directed.`, + Description: `The base URL of your GitLab instance. This could be the URL of a self-managed GitLab instance or the URL of the GitLab SaaS service (https://gitlab.com). The URL must be properly formatted, including the scheme (http or https). This field is essential as it determines the endpoint where API requests will be directed.`, }, "type": { Type: framework.TypeString, @@ -43,7 +43,7 @@ var ( TypeSaaS, TypeDedicated, }, - Description: `The type of GitLab instance you are connecting to. This could typically distinguish between 'self-hosted' for on-premises GitLab installations or 'saas' or 'dedicated' for the GitLab SaaS offering. This field helps the plugin to adjust any necessary configurations or request patterns specific to the type of GitLab instance.`, + Description: `The type of GitLab instance you are connecting to. This could typically distinguish between 'self-managed' for on-premises GitLab installations or 'saas' or 'dedicated' for the GitLab SaaS offering. This field helps the plugin to adjust any necessary configurations or request patterns specific to the type of GitLab instance.`, DisplayAttrs: &framework.DisplayAttributes{ Name: "GitLab Type", },