Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-102): add service account token type for gitlab.com accounts #105

Closed
wants to merge 7 commits into from

Conversation

GavinCS
Copy link

@GavinCS GavinCS commented Jul 30, 2024

No description provided.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 84.84848% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.89%. Comparing base (8942fbd) to head (099001a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
path_token_role.go 45.45% 3 Missing and 3 partials ⚠️
gitlab_client.go 91.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   89.16%   88.89%   -0.27%     
==========================================
  Files          16       16              
  Lines        1052     1117      +65     
==========================================
+ Hits          938      993      +55     
- Misses         65       70       +5     
- Partials       49       54       +5     
Flag Coverage Δ
unittests 88.89% <84.84%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilijamt
Copy link
Owner

ilijamt commented Aug 31, 2024

@GavinCS I was going through the documentation of GitLab and I saw that there are two types of service accounts, one are User Service Accounts (the one that require admin access), and the other ones are Group Service Accounts. Both require at least Premium Tier subscription. At the moment, I don't have access to the subscription. Do you by any chance can help me test on the Premium account or if you can give access to my user, so I can test it?

I created #110 that would allow us to select the proper GitLab type and service account type.

@ilijamt
Copy link
Owner

ilijamt commented Aug 31, 2024

I've also asked GitLab Sales if they can provide a license, so I can fully test and develop the service account features. Hopefully they come back with a positive reply.

@GavinCS
Copy link
Author

GavinCS commented Sep 2, 2024

@ilijamt I won't be able to give you access to our Group in Gitlab but I could probably setup an isolated group that we can test with. Gitlab providing a license would be first class - If you gice me the details of your ticket I can also try push with our account manager

@ilijamt
Copy link
Owner

ilijamt commented Sep 27, 2024

Finally got the license. So I'll get this finished soon.

@ilijamt
Copy link
Owner

ilijamt commented Oct 10, 2024

Implemented in #110

@ilijamt ilijamt closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants