When ai in the boat and close land

[Aiden-Wei]

Preliminary checks

• I've checked that there aren't other open issues on the same topic.
• I've checked that this issue is reproducible on the latest snapshot build.

Platform

Windows

Describe the bug

When ai in the boat and close land

Save file

Additional info

No response

[ihhub]

@Aiden-Wei , this information tells nothing about the issue. Please be very specific and provide all necessary details.

[oleg-derevenetz]

Hi @ihhub

This seems to be triggered by the assertion that I added recently in #9140:

fheroes2/src/fheroes2/world/world_pathfinding.cpp

Lines 225 to 230 in e4d531b

	// AI can use boats to overcome water obstacles
	if ( objectType == MP2::OBJ_BOAT ) {
	assert( !fromWater && toWater );
	return true;
	}

It wasn't there before, but in theory, AI should never try to pass through a tile with OBJ_BOAT if it is not going to board the boat at the same time (that is, the direction should be shore -> boat and nothing else). Thanks to this assertion, I found #9141, when the AI's path ran through a boat located on a Whirlpool tile (BTW, it would be nice if someone who is well aware of the map internals looked at it and suggested a way to properly restore the Whirlpool tile after a boat).

Hi @Aiden-Wei we need a save file and a description of how to reproduce the issue (preferably with a demo video).