Should deleting OtpUser also delete that user's MonitoredTrip, TripRequest, and TripSummary?

[binh-dam-ibigroup]

Observed behavior

While reviewing this file, I'm realizing that upon deleting an OtpUser, we don't have a preDeleteHook to delete the following associated entities:

• MonitoredTrip,
• TripRequest,
• TripSummary.

Should we?

[landonreed]

We just handled this in #64, did we not?

otp-middleware/src/main/java/org/opentripplanner/middleware/models/OtpUser.java

Lines 50 to 65 in 9b9d54a

	// Delete trip request history (related trip summaries are deleted in TripRequest#delete)
	for (TripRequest request : TripRequest.requestsForUser(this.id)) {
	boolean success = request.delete();
	if (!success) {
	LOG.error("Error deleting user's ({}) trip request {}", this.id, request.id);
	return false;
	}
	}
	// Delete monitored trips.
	for (MonitoredTrip trip : MonitoredTrip.tripsForUser(this.id)) {
	boolean success = trip.delete();
	if (!success) {
	LOG.error("Error deleting user's ({}) monitored trip {}", this.id, trip.id);
	return false;
	}
	}

[binh-dam-ibigroup]

Thanks, so that is probably redundant code I saw in #78.