Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SERVICE_DAY_START_HOUR config param #144

Open
binh-dam-ibigroup opened this issue Jun 10, 2021 · 0 comments
Open

Remove SERVICE_DAY_START_HOUR config param #144

binh-dam-ibigroup opened this issue Jun 10, 2021 · 0 comments
Assignees
@binh-dam-ibigroup

Comments

@binh-dam-ibigroup
Copy link
Collaborator

binh-dam-ibigroup commented Jun 10, 2021 •
edited
Loading

Observed behavior

The determination of the day on which an itinerary with transit happens is currently done using the itinerary start/arrive time and the SERVICE_DAY_START_HOUR config param. This approach is redundant with the serviceDate field on itinerary legs for itineraries returned by OTP.

This issue is related to opentripplanner/otp-react-redux#385 and opentripplanner/otp-react-redux#372.

Expected behavior

The determination of the day on which an itinerary with transit happens should use the serviceDate field returned by OTP.

Steps to reproduce the problem

NA

Any special notes on configuration used

NA

Version of otp-middleware and/or OpenTripPlanner if applicable (exact commit hash or branch name)

recent code on the dev branch.
@binh-dam-ibigroup binh-dam-ibigroup self-assigned this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binh-dam-ibigroup