Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feed version notification only applies to fetch method #277

Open
landonreed opened this issue Feb 3, 2020 · 0 comments
Open

New feed version notification only applies to fetch method #277

landonreed opened this issue Feb 3, 2020 · 0 comments
Labels

Comments

@landonreed
Copy link
Contributor

landonreed commented Feb 3, 2020

There are a handful of methods to create a new version (fetch, upload, create from snapshot), but the only one that triggers an email notification is the fetch method.

NotifyUsersForSubscriptionJob.createNotification(
"feed-updated",
this.id,
String.format("New feed version created for %s.", this.name));

One justification for only notifying on fetch is that the fetch could happen overnight in a daily auto-fetch and users would obviously want to know about the new version in this context. Other version creation methods are a bit more manual, so there is less concern about notifying users about something they may have initiated. On the other hand, we make these same notifications in other contexts (e.g., project updated) and there are often more than one user that may find the information about a new version helpful. So I think it is appropriate to expand this notification to other version creation methods as well.

@landonreed landonreed added the bug label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant