-
Notifications
You must be signed in to change notification settings - Fork 18
Support install from package manager #9
Comments
Hi Edwin,
That guide is useful to get started, but there are few points that needs to be clarified (by Unity people) so we can build on top of that. If not this is what I think about the subject, but if you feel confident about making this work, that would be really cool and helpful! |
Hi, Thanks for your detail reply. All your points are valid and i agreed that it is kind of waste of time at this moment. Do you recommend any installation method which others (like me) to use this project as a library ? How about git-submodule to package folder , Unity asset package or others ? |
To be honest, UPM packages are the ideal, at least when some of these concerns are addressed. If I was to manage dependencies in a future/recent project, I would do them temporarily manually until I'm ready to migrate to using UPM. |
I finally manage to convert it to using UPM : https://github.com/edwin0cheng/ImageEffectGraph/tree/support_upm Which solve parts of your concerns:
to update the And here is a demo project which you can play around and test it : |
Awesome, thank you for giving it a try, I'll try to review it as soon as I can (probably over the weekend) |
Hi Edwin, If you would like to contribute your changes through a pull request, I have few remarks:
Thank you very much! |
In 2018.3.0b7 added support for git package dependencies from package manager :
https://forum.unity.com/threads/git-support-on-package-manager.573673/
Here is the guide to make a custom package:
https://gist.github.com/LotteMakesStuff/6e02e0ea303030517a071a1c81eb016e
Do you think this is a good idea to support it ? If so, i could try to make a PR.
The text was updated successfully, but these errors were encountered: