Skip to content
This repository has been archived by the owner on Aug 14, 2021. It is now read-only.

Make the download button prompt the browser to directly download the extension and add a button to view the source code #15

Open
alice-blue opened this issue Apr 15, 2017 · 1 comment

Comments

@alice-blue
Copy link

matt w suggested having dedicated download buttons that will actually download the extensions, rather than just showing the source code, which is not as newbie-friendly. Details at intfiction.org.

zarf said:

Might want to have separate urls for the same content, one with "Content-Disposition: attachment", one with "inline" (the current behavior).

(Maybe add "?display=true" as an argument to get the inline version?)

@curiousdannii
Copy link
Member

curiousdannii commented Apr 15, 2017

IIRC, the issue is not so much attachment vs inline, but the content-type: https://github.com/i7/i7el/blob/master/web/controllers/extensions.js#L387
If the type is set to text/x-natural-inform-extension but it remains as inline then it will download.

I had preferred having it display the code, but I can see the argument that the Download button should initiate the browser's download function. Underneath the Download button I could have a view source button.

I'm sure I had it working previously, but the Content-Disposition filename isn't working for me in Chrome currently either :/

@curiousdannii curiousdannii changed the title feature request: Newbie-friendly downloading of extensions Make the download button prompt the browser to directly download the extension and add a button to view the source code Apr 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants