Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Instrumentation #34

Open
shorsher opened this issue Sep 16, 2022 · 1 comment
Open

Prometheus Instrumentation #34

shorsher opened this issue Sep 16, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@shorsher
Copy link
Member

shorsher commented Sep 16, 2022

While the http metrics and manager are going to be instrumented in FFTM in hyperledger/firefly-transaction-manager#38, it will still be useful for evmconnect to create its own custom metrics.

See https://github.com/hyperledger/firefly/blob/0b6c289ffee87330f578796d5ece8268216e133f/internal/metrics/prometheus.go for the firefly implementation of http and custom metrics.

One metric that could be useful, is a counter for each submitted transaction.

@nguyer nguyer added the good first issue Good for newcomers label Sep 16, 2022
@vishalrajofficial
Copy link

Adding this in function initMetricsCollectors() may resolve the issue:

submittedTransactionsCounter = prometheus.NewCounter(
prometheus.CounterOpts{
Namespace: "evmconnect",
Name: "submitted_transactions_total",
Help: "Total number of submitted transactions in EVMConnect.",
},
)
registry.MustRegister(submittedTransactionsCounter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants