Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evmconnect does not respect HTTP 429 #135

Open
awrichar opened this issue May 15, 2024 · 1 comment
Open

evmconnect does not respect HTTP 429 #135

awrichar opened this issue May 15, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@awrichar
Copy link
Contributor

When processing RPC requests, a node may request the caller to slow down by giving an HTTP 429 response.

evmconnect does not seem to handle this response properly. The correct behavior would be to pause all RPC requests for some amount of time. If the response specifies a Retry-After header, than that should be respected, but otherwise a random delay (of a few seconds) can be selected.

Currently, evmconnect has a pretty aggressive retry behavior - so it continues to hammer the node even while receiving multiple HTTP 429 responses (which makes the situation worse and can result in being blocked from making further requests).

@Chengxuan Chengxuan added the bug Something isn't working label May 15, 2024
@EnriqueL8 EnriqueL8 added enhancement New feature or request and removed bug Something isn't working labels Jul 17, 2024
@EnriqueL8
Copy link
Contributor

Switch to enhancement as it's something that doesn't exist and would be nice to have

@EnriqueL8 EnriqueL8 added the good first issue Good for newcomers label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants