Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command line argument to allow me to set max blobs if Im a proposer #7683

Open
rolfyone opened this issue Sep 26, 2024 · 5 comments
Open
Assignees

Comments

@rolfyone
Copy link
Contributor

rolfyone commented Sep 26, 2024

Sometimes there's a confluence of circumstances that ends up meaning that a solo staker may be proposing, with a local EL building, and needing to include 6 blobs currently.

Because of a number of factors, this may mean a large volume of data (roughly 80-100MB for 6 blobs - corrected down after twitter discussion) being pushed out of a home internet which may only be ADSL, and this can ultimately lead to missed block proposals.

As a home staker, I would like to be able to dictate the maximum number of blobs for inclusion in a block that I'm building, so that I can have the best chance of publishing the block for inclusion.

Clearly this still needs to apply normal max rules, so if i set --max-blobs=1000, that would be invalid, but I'd like to be able to do something like set --max-blobs=3, or even --max-blobs=1 if i know that I'm unlikely to be able to publish larger volumes of data given my internet circumstances.

There's also no financial incentive for a block producer to produce large amounts of blob data, so the fact that these large objects can ruin my proposals seems very unfair. I'd rather get a block out in time than miss a proposal completely.

@Deepcryptodive
Copy link

Deepcryptodive commented Sep 26, 2024

Yes please! I'm a home staker doing local building and would use this.

Currently I'm using Starlink as ISP, and bandwith can be an issue sometimes!

@jflo jflo self-assigned this Sep 26, 2024
@jflo
Copy link
Contributor

jflo commented Sep 27, 2024

There is no option to fine-tune the number of blobs to include in a produced block, however the inclusion of blobs can be disabled altogether using the existing tx-pool-max-prioritized-by-type configuration option but the validator would have to be willing to forfeit the blob fees for their proposed block.

@benaadams
Copy link

Similar request in Nethermind NethermindEth/nethermind#7502

@benjaminion
Copy link

There is no option to fine-tune the number of blobs to include in a produced block, however the inclusion of blobs can be disabled altogether using the existing tx-pool-max-prioritized-by-type configuration option

Can you clarify the syntax for this? When I put the following in the config file (as per the example in the docs):

tx-pool-max-prioritized-by-type="BLOB=0"

I get this error on startup:

TomlInvalidTypeException: Value of 'tx-pool-max-prioritized-by-type' is a string while processing argument at or before arg[1] '/etc/besu/besu.toml' in [--config-file, /etc/besu/besu.toml]: org.apache.tuweni.toml.TomlInvalidTypeException: Value of 'tx-pool-max-prioritized-by-type' is a string

I have tried many variants of this (adding escaped quotes around "0", changing up the quotation mark types, omitting the quotation marks...), but no success.

@jflo
Copy link
Contributor

jflo commented Sep 27, 2024

You've found a documentation error, thank you. The value for the option is an array:

tx-pool-max-prioritized-by-type=["BLOB=0","FRONTIER=200"]

is how it is tested (successfully) in our test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants