Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OKX wallet / explicitly surface Keplr errors #85

Open
tkporter opened this issue Nov 21, 2023 · 3 comments · Fixed by #89
Open

Support OKX wallet / explicitly surface Keplr errors #85

tkporter opened this issue Nov 21, 2023 · 3 comments · Fixed by #89
Assignees
Labels
bug Something isn't working UX end user experience warp-UI

Comments

@tkporter
Copy link
Contributor

tkporter commented Nov 21, 2023

Someone in Discord was having intermittent issues with Keplr wallet. They also had the OKX wallet installed. Sometimes when trying to connect to Keplr, the OKX wallet would silently take precedence. The addresses in the side panel would relate to the OKX wallet addresses despite saying "Keplr" on them. We should:

  • Either explicitly support the OKX wallets / show them on the right side as "OKX" and surface to the user there was an error with Keplr
  • Just surface errors connecting to Keplr and have the user try again

Context

@tkporter tkporter changed the title Do not fall back to an injected wallet if there's an error with Keplr Do not silently fall back to another wallet if there's an error with Keplr Nov 21, 2023
@avious00 avious00 added the bug Something isn't working label Nov 21, 2023
@avious00 avious00 changed the title Do not silently fall back to another wallet if there's an error with Keplr Support OKR wallet / explicitly surface Keplr errors Dec 14, 2023
@avious00 avious00 changed the title Support OKR wallet / explicitly surface Keplr errors Support OKX wallet / explicitly surface Keplr errors Dec 14, 2023
@jmrossy
Copy link
Collaborator

jmrossy commented Dec 14, 2023

I tested this with the latest wagmi/rainbowkit (branch off #89) and I don't see any errors. It's possible this issues was fixed in a recent update.

@jmrossy
Copy link
Collaborator

jmrossy commented Mar 19, 2024

Reopening to further investigate OKX issues

@jmrossy jmrossy reopened this Mar 19, 2024
@jmrossy
Copy link
Collaborator

jmrossy commented Mar 19, 2024

I've done some more testing with OKX mixed with other wallets in Chrome:

  • OKX has a Set as default wallet setting that is enabled by default
  • OKX consistently overrides Metamask; I cannot use Metamask when OKX is enabled
  • OKX will impersonate Keplr if Keplr is not enabled/installed
  • I cannot repro OKX overriding Keplr or Leap when they're all enabled

So TLDR, I can confirm OKX is willing to masquerade as another wallet but I can't repro the exact issue the user saw. It's possible that some users are clicking the Keplr option without realizing they don't have it installed, causing it to actually connect to OKX instead.

AFAI can tell, there is no way to differentiate from Metamask/Keplr vs OKX when OKX is impersonating those other wallets.

I'm testing with the latest version of all extensions. Maybe this bug requires an older version.

In terms of next steps, if I can't get any a reproduction of the bug, I don't think I can look for workarounds. We could try UX solutions, like forcing a confirmation modal for the user to accept.

Finally, I'll just add that the Warp UI is not the only DApp feeling this pain. There's an EIP that Pedro from WalletConnect has been leading which alleviates it but wallets must each buy-in: https://twitter.com/pedrouid/status/1765822163829862589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UX end user experience warp-UI
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants