Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking issue] General dataset support #2071

Open
16 of 40 tasks
qgallouedec opened this issue Sep 15, 2024 · 0 comments
Open
16 of 40 tasks

[Tracking issue] General dataset support #2071

qgallouedec opened this issue Sep 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@qgallouedec
Copy link
Member

qgallouedec commented Sep 15, 2024

The aim is for all trainers to apply the same procedure in their init function:

  • if needed, apply the chat template, then
  • if needed, tokenize.

Support todo:

Standard dataset

  • BCOTrainer
  • CPOTrainer
  • DPOTrainer
  • GKDTrainer (same as SFTTrainer)
  • IterativeSFTTrainer
  • KTOTrainer
  • NashMDTrainer
  • OnlineDPOTrainer
  • ORPOTrainer
  • PPOv2Trainer
  • RewardTrainer [RewardTrainer] Tokenize inputs within trainer #2102
  • SFTTrainer (via "dataset_text_field", needs refactoring)
  • XPOTrainer

Conversational dataset

Tokenized dataset (to be discussed, do we want this?)

  • BCOTrainer
  • CPOTrainer
  • DPOTrainer
  • GKDTrainer
  • IterativeSFTTrainer
  • KTOTrainer
  • NashMDTrainer
  • OnlineDPOTrainer
  • ORPOTrainer
  • PPOv2Trainer
  • RewardTrainer
  • SFTTrainer (yes, via custom collate_fn and dataset_kwargs={"skip_prepare_dataset": True},, needs refactoring)
  • XPOTrainer

Misc

  • Update docs/dataset_format.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant