Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when attempting to load a large playlist #1506

Open
tomasguinzburg opened this issue Aug 19, 2024 · 1 comment
Open

Crashes when attempting to load a large playlist #1506

tomasguinzburg opened this issue Aug 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tomasguinzburg
Copy link

tomasguinzburg commented Aug 19, 2024

Describe the bug
When attempting to reproduce a playlist from the search with ~1000 tracks, the program freezes.

To Reproduce
Steps to reproduce the behavior:

  1. Press F2 to search.
  2. Write "Disclosure's Record Bag" on the search, hit intro.
  3. Navigate to playlists (triple right arrow on my mappings)
  4. Hit intro on top of the playlist "Disclosure's Record Bag - Disclosure" as shown in the screenshot
  5. Program should stop audio and freeze, can't be killed without killing terminal.

Expected behavior
Playlist is added to queue and starts reproducing

Screenshots
image

System (please complete the following information):

  • OS: macOS 14.3.1 arm M1
  • Terminal: [kitty, iTerm2] reproduced in both.
  • Version: 1.1.1
  • Installed from: cargo

Backtrace/Debug log
No crash, just frozen

Additional context
Low CPU load even when frozen, computer should be able to handle it pretty well. Playlist has an emoji in the name, and there are some song titles with weird characters (One by Four Tet has very weird characters). I'm not too sure what other tests I can run, happy to help.

I tried the 4th playlist for me, by Deli Paloma-Sisk with 1027 songs, and that one works although it sometimes doesn't, displaying 0 songs but without freezing.

@tomasguinzburg tomasguinzburg added the bug Something isn't working label Aug 19, 2024
@tomasguinzburg
Copy link
Author

ncdebug.log

I see this error repeatedly:

[2024-08-19][17:11:08] [ncspot::spotify_api] [ERROR] unhandled api error: json parse error: data did not match any variant of untagged enum PlayableItem at line 1 column 26378

And also a lot of HTTP 429, possible because of the size of the playlist the pagination is hitting rate limits. However, the pagination doesn't seem to advance either, it's always requesting with offset=100 and limit=100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant