-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when trying to load deleted(?) song #1467
Comments
Could you link that playlist? I looked at https://open.spotify.com/playlist/2KnF9S8AQ9bNsBmzQmnqsJ (as indicated in the logs) but it seems to be a different one? EDIT: Ah, the dynamic "Discover Weekly" has probably been refreshed now.. 😞 |
Yes, its a dynamic one. I could try to create one and wait for it to have a song deleted, but it would really be a shot in the dark. |
I will try to add an already deleted track to a test playlist via the API. Since the song still exists and still has metadata (title, author, etc), it must still have an ID. It will just be a matter if spotify allows that operation or not. |
Describe the bug
So, as we all know, a "Discover Weekly" playlist is made (or updated, idk) every week. My problem is, when I was trying to play it, the program crashed. The issue is there is a song in that playlist that I assume existed when the playlist was created, but then the song was deleted for some reason. Ncspot doesn't account for that, and tries to play it, thus crashing the application.
Maybe it is the playing that causes the issue, but from the backtrace I feel like it is an UI error because it tries to set the current length that was played from the song, but since it doesn't exist, Spotify's API returns a zero. But I feel like the solution should not just be guarding against that, but just to skip songs that have a 0 length (or not even trying to play them).
To Reproduce
I tried reproducing with local files, but to no avail. If it's possible to access the playlist by id without authenticating as me, or adding the offending song (from the logs) to an existing playlist would be best, but otherwise I really have no ideas here.
Expected behavior
I would expect the application to skip or ignore songs that no longer exist on the platform, or that have no valid reference to (thinking about local files).
Screenshots
Official spotify client
Ncspot
System (please complete the following information):
Backtrace/Debug log
Backtrace log
Empty spaces after the lines are 'unknown' elements
Details
The text was updated successfully, but these errors were encountered: