Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 Incompatibility: can download, but not upload existing game #82

Open
CrsiX opened this issue Jun 18, 2023 · 2 comments
Open

V1 Incompatibility: can download, but not upload existing game #82

CrsiX opened this issue Jun 18, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@CrsiX
Copy link
Member

CrsiX commented Jun 18, 2023

Version
v5.0-alpha2

Server
https://uncivserver.xyz

Describe the bug
Any existing game can be loaded but not uploaded.

To Reproduce
Unknown. Investigating ...

Originally reported by @touhidurrr

@CrsiX CrsiX added the bug Something isn't working label Jun 18, 2023
@CrsiX
Copy link
Member Author

CrsiX commented Jun 18, 2023

When uploading a new game from the NewGameScreen, it fails with the following error:

2023-06-18T09:28:39.823125Z [threadpool-nondaemon-0] [SimpleHttp] Returning error message [Bad Request!]
2023-06-18T09:28:39.823359Z [threadpool-nondaemon-0] [UncivServerFileStorage$saveGameData] Error from UncivServer during save: Bad Request!
2023-06-18T09:28:39.823876Z [threadpool-nondaemon-0] [NewGameScreen$startNewGame] [ERROR] Error while creating game | java.lang.Exception: Bad Request!
	at com.unciv.logic.multiplayer.storage.UncivServerFileStorage$saveGameData$2.invoke(UncivServerFileStorage.kt:20)
	at com.unciv.logic.multiplayer.storage.UncivServerFileStorage$saveGameData$2.invoke(UncivServerFileStorage.kt:14)
	at com.unciv.logic.multiplayer.storage.SimpleHttp.sendRequest(SimpleHttp.kt:67)
	at com.unciv.logic.multiplayer.storage.UncivServerFileStorage.saveGameData(UncivServerFileStorage.kt:14)
	at com.unciv.logic.multiplayer.storage.OnlineMultiplayerFiles.tryUploadGame(OnlineMultiplayerFiles.kt:67)
	at com.unciv.logic.multiplayer.OnlineMultiplayer.createGame(OnlineMultiplayer.kt:210)
	at com.unciv.ui.screens.newgamescreen.NewGameScreen$startNewGame$2.invokeSuspend(NewGameScreen.kt:308)
	at com.unciv.ui.screens.newgamescreen.NewGameScreen$startNewGame$2.invoke(NewGameScreen.kt)
	at com.unciv.ui.screens.newgamescreen.NewGameScreen$startNewGame$2.invoke(NewGameScreen.kt)
	at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:89)
	at kotlinx.coroutines.CoroutineScopeKt.coroutineScope(CoroutineScope.kt:264)
	at com.unciv.ui.screens.newgamescreen.NewGameScreen.startNewGame(NewGameScreen.kt:279)
	at com.unciv.ui.screens.newgamescreen.NewGameScreen.access$startNewGame(NewGameScreen.kt:49)
	at com.unciv.ui.screens.newgamescreen.NewGameScreen$onStartGameClicked$5.invokeSuspend(NewGameScreen.kt:213)
	at com.unciv.ui.screens.newgamescreen.NewGameScreen$onStartGameClicked$5.invoke(NewGameScreen.kt)
	at com.unciv.ui.screens.newgamescreen.NewGameScreen$onStartGameClicked$5.invoke(NewGameScreen.kt)
	at com.unciv.utils.concurrency.ConcurrencyKt$launchCrashHandling$1.invokeSuspend(Concurrency.kt:83)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at com.unciv.utils.concurrency.CrashHandlingDispatcher$dispatch$1.invoke(Concurrency.kt:164)
	at com.unciv.utils.concurrency.CrashHandlingDispatcher$dispatch$1.invoke(Concurrency.kt:164)
	at com.unciv.ui.crashhandling.CrashHandlingExtensionsKt$wrapCrashHandling$1.invoke(CrashHandlingExtensions.kt:17)
	at com.unciv.ui.crashhandling.CrashHandlingExtensionsKt$wrapCrashHandlingUnit$1.invoke(CrashHandlingExtensions.kt:33)
	at com.unciv.ui.crashhandling.CrashHandlingExtensionsKt$wrapCrashHandlingUnit$1.invoke(CrashHandlingExtensions.kt:33)
	at com.unciv.utils.concurrency.CrashHandlingDispatcher.dispatch$lambda$0(Concurrency.kt:164)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

@CrsiX
Copy link
Member Author

CrsiX commented Jun 18, 2023

Probably duplicate of #57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant