Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Editor - Rename File popup doesn't start with cursor in new file input box #2033

Closed
dagwud opened this issue May 24, 2021 · 3 comments
Closed

Comments

@dagwud
Copy link

dagwud commented May 24, 2021

The problem

Really small and silly request, but in the File Editor (Configurator) addon, the "Rename" menu brings up a popup to prompt for the file name, but the caret is not placed in the input box. A small usability fix (putting the cursor in the text box to allow you to just start typing) would be nice. When doing housekeeping and renaming a bunch of files, this extra click is pesky.

Environment

HAOS 5.13
core-2021.5.5
supervisor-2021.04.3

  • Add-on with the issue: File Editor (Configurator)
  • Add-on release with the issue: 5.3.0
  • Last working add-on release (if known): None known
  • Operating environment (OS/Supervised): OS

Problem-relevant configuration

Steps to reproduce:

  • Open File Editor
  • Click the "Browse Filesystem" icon
  • Click on the "..." next to any file name
  • Click Rename
  • Note the popup which asks "Please enter a new name for " - if you just start typing, nothing happens as the cursor is not placed in the input box

Traceback/Error logs

None relevant

Additional information

I debated whether this issue should be filed here or in 'frontend', but my logic says the frontend issue tracker is more for central UI, not plugin-specific UI, which I would guess this is. If this is incorrectly logged, apologies - please refer me appropriately.

@dagwud
Copy link
Author

dagwud commented May 24, 2021

Just confirmed, to be sure - still a problem in File Editor 5.3.1, which I hadn't yet noticed was available

@frenck
Copy link
Member

frenck commented May 25, 2021

Hi there @dagwud 👋

Add-ons wrap existing application, and thus the applications themselves are not developed here.
Changes like these need to be suggested upstream, once it has been fixed/added, we can update the application running in the add-on.

Please report your suggestion here:

https://github.com/danielperna84/hass-configurator

Thanks!

../Frenck

@dagwud
Copy link
Author

dagwud commented May 26, 2021

Thanks Frenck! TIL. I was puzzled at not being able to see the addon code itself in the repo; now I understand a bit better.

Logged request at danielperna84/hass-configurator#215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants