build: generate client with openapi-typescript #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://token-metadata-cyhoaearf-hirosystems.vercel.app 🚀 |
rafaelcr
commented
Oct 9, 2024
| "scripts": { | ||
| "prepublishOnly": "npm run build", | ||
| "build": "rimraf ./lib && npm run build:client --prefix .. && npm run build:node && npm run build:browser", | ||
| "build:node": "tsc && cp -R src/generated lib/generated", |
There was a problem hiding this comment.
@zone117x I noticed you didn't copy the generated types to the lib dir in the Stacks API client. Not sure why that never worked for me in my tests so I had to do this instead. I also tried including the src directory in the "files" entry in this file but it made no difference because the included path was still incorrect.
Let me know if you have other ideas.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the TS client to be generated with
openapi-typescriptinstead ofswagger-codegen. This allows us to ship it for recentnodeandtypescriptversions.Fixes #268
Fixes #193