Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response to GET status request to the Devnet API should distinguish btwn there being missing devnet assets (404) and the devnet spinning down #81

Open
BLuEScioN opened this issue Nov 2, 2023 · 2 comments

Comments

@BLuEScioN
Copy link

BLuEScioN commented Nov 2, 2023

Is it possible for the GET status request to the Devnet API to return a response that distinguishes between there being missing devnet assets (404) and the devnet spinning down

The platform client can derive this from client state, but it would be great to have this returned from the api so that the state is durable

@andresgalante
Copy link
Member

@BLuEScioN is this something that can wait till Micahia is back?

@MicaiahReid
Copy link
Contributor

Adding some notes to clarify for myself in the future.

Currently, if a devnet has been created then deleted by the platform backend, the platform backend polls the devnet API with a HEAD request to wait for it to return a 404. A 200 response indicates that devnet assets still exist (and thus are still being deleted), and a 404 response indicates that there are no devnet assets for that id (and thus the devnet has been successfully deleted).

This is sufficient for managing state, but it requires the platform to manage this state. If that state gets messed up somehow, the platform backend can't just query the devent API to know "is this devnet running, shutting down, spinning up, or shut down". It will take some research to know if we can query the k8s api from within the devnet api to determine this info.

For now, however, this isn't a high priority, as everything is working as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants