Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAddressMempoolTransactions does not support smart contracts #1685

Closed
friedger opened this issue Jul 6, 2023 · 1 comment · Fixed by #1704
Closed

getAddressMempoolTransactions does not support smart contracts #1685

friedger opened this issue Jul 6, 2023 · 1 comment · Fixed by #1704
Assignees
Milestone

Comments

@friedger
Copy link
Contributor

friedger commented Jul 6, 2023

Describe the bug
transactionApi.getAddressMempoolTransactions fails with error Invalid query parameter for "SP21YTSM60CAY6D011EZVEVNKXVW8FVZE198XEFFP.pox-fast-pool-v2" while accountsApi.getAccountTransactions works with contract parameters.

It would be nice to also retrieve mempool transactions filtered by the contract address.

Additional context
getHasPendingTransactions fails for FAST pool
https://github.com/hirosystems/lockstacks/blob/b31f6cd53d8c127458a2e1a4be9fd6b147967748/src/pages/stacking/direct-stacking-info/utils-pending-txs.ts#L72

@zone117x
Copy link
Member

zone117x commented Jul 7, 2023

This seems reasonable and relatively simple to implement.

@smcclellan smcclellan added this to the Q3-2023 milestone Jul 26, 2023
blockstack-devops pushed a commit that referenced this issue Nov 16, 2023
## [7.4.0-nakamoto.1](v7.3.2...v7.4.0-nakamoto.1) (2023-11-16)

### Features

* add dataset store ([4211328](4211328))
* add step to compile duckdb for Alpine image ([0f40e14](0f40e14))
* better handling of raw events insertion ([bb70ca9](bb70ca9))
* event-replay new_block events handling ([1708b42](1708b42))
* event-replay new_burn_block events handling ([6c0f448](6c0f448))
* event-replay raw events handling ([81f43cf](81f43cf))
* event-replay remainder events handling ([3ede07f](3ede07f))
* event-replay supporting parallel insertions ([f33ecee](f33ecee))
* events folder as environment var ([701bd1a](701bd1a))
* parallel processing using node cluster ([d02a7e8](d02a7e8))
* processing raw events in parallel ([7a6f241](7a6f241))

### Bug Fixes

* add token offering ([8ef039e](8ef039e))
* allow contract-principals in `/extended/v1/address/:principal/mempool` endpoint [#1685](#1685) ([#1704](#1704)) ([163b76a](163b76a))
* better args handlling ([c77ac57](c77ac57))
* better path handling for workers ([1bd8f17](1bd8f17))
* changed processing order ([62a12bd](62a12bd))
* convert `chain_tip` materialized view into a table ([#1751](#1751)) ([04b71cc](04b71cc))
* flaky test ([484d2ea](484d2ea))
* flaky test ([65175f5](65175f5))
* lint ([01589ea](01589ea))
* lint ([82eadcb](82eadcb))
* lint ([8c67ae5](8c67ae5))
* on attachments_new events processing ([0707313](0707313))
* re-enable indexes when finishing the replay ([fc379eb](fc379eb))
* remove dangling promise ([62a48ae](62a48ae))
* revert configurable DB index type ([86154b2](86154b2))
* upgrade semver package to fix ReDoS vulnerability ([6b1605b](6b1605b))
blockstack-devops pushed a commit that referenced this issue Jan 9, 2024
## [7.6.0-nakamoto.1](v7.5.0...v7.6.0-nakamoto.1) (2024-01-09)

### Features

* `GET /extended/v1/burn_block` ([#1766](#1766)) ([cb38b68](cb38b68))
* add `/extended/v2/blocks/:height_or_hash` ([#1774](#1774)) ([e532a5e](e532a5e))
* add `/extended/v2/blocks` endpoint with burn block filters ([#1769](#1769)) ([ceb7be0](ceb7be0))
* add `tx_count` property to `/extended/v2/blocks` ([#1778](#1778)) ([da4cd56](da4cd56))
* add dataset store ([4211328](4211328))
* add step to compile duckdb for Alpine image ([0f40e14](0f40e14))
* better handling of raw events insertion ([bb70ca9](bb70ca9))
* create `/extended/v2/burn-blocks/:height_or_hash/blocks` endpoint ([#1782](#1782)) ([20466a1](20466a1))
* disable rosetta via an ENV var ([#1804](#1804)) ([2d2aee3](2d2aee3))
* event-replay new_block events handling ([1708b42](1708b42))
* event-replay new_burn_block events handling ([6c0f448](6c0f448))
* event-replay raw events handling ([81f43cf](81f43cf))
* event-replay remainder events handling ([3ede07f](3ede07f))
* event-replay supporting parallel insertions ([f33ecee](f33ecee))
* events folder as environment var ([701bd1a](701bd1a))
* ingestion for `TenureChange` and `NakamotoCoinbase` tx types ([#1753](#1753)) ([7c45f53](7c45f53))
* parallel processing using node cluster ([d02a7e8](d02a7e8))
* pox-4 support ([#1754](#1754)) ([285806f](285806f))
* processing raw events in parallel ([7a6f241](7a6f241))
* update to latest TenureChange tx payload ([#1767](#1767)) ([2afb65c](2afb65c))

### Bug Fixes

* add token offering ([8ef039e](8ef039e))
* allow contract-principals in `/extended/v1/address/:principal/mempool` endpoint [#1685](#1685) ([#1704](#1704)) ([163b76a](163b76a))
* better args handlling ([c77ac57](c77ac57))
* better path handling for workers ([1bd8f17](1bd8f17))
* changed processing order ([62a12bd](62a12bd))
* convert `chain_tip` materialized view into a table ([#1751](#1751)) ([04b71cc](04b71cc))
* do not load duckdb binary unless required ([#1776](#1776)) ([db859ae](db859ae))
* flaky test ([484d2ea](484d2ea))
* flaky test ([65175f5](65175f5))
* handle `Problematic` status in `/drop_mempool_tx` event ([#1790](#1790)) ([ce9b38f](ce9b38f))
* import statement in replay controller ([7a10cd8](7a10cd8))
* insert block transaction data in batches ([#1760](#1760)) ([bf99e90](bf99e90))
* lint ([01589ea](01589ea))
* lint ([82eadcb](82eadcb))
* lint ([8c67ae5](8c67ae5))
* move `/extended/v1/burn_block` to `/extended/v2/burn-blocks` ([#1772](#1772)) ([bf2ef0a](bf2ef0a))
* on attachments_new events processing ([0707313](0707313))
* optimize mempool transaction reads and writes ([#1781](#1781)) ([3a02f57](3a02f57))
* re-enable indexes when finishing the replay ([fc379eb](fc379eb))
* remove dangling promise ([62a48ae](62a48ae))
* remove deprecated token endpoints ([#1775](#1775)) ([18f74b7](18f74b7))
* revert configurable DB index type ([86154b2](86154b2))
* upgrade semver package to fix ReDoS vulnerability ([6b1605b](6b1605b))
* vercel preview builds ([#1783](#1783)) ([d36b1c2](d36b1c2))
blockstack-devops pushed a commit that referenced this issue Jan 9, 2024
## [7.6.0](v7.5.0...v7.6.0) (2024-01-09)

### Features

* `GET /extended/v1/burn_block` ([#1766](#1766)) ([cb38b68](cb38b68))
* add `/extended/v2/blocks/:height_or_hash` ([#1774](#1774)) ([e532a5e](e532a5e))
* add `/extended/v2/blocks` endpoint with burn block filters ([#1769](#1769)) ([ceb7be0](ceb7be0))
* add `order_by` and `order` params to `/extended/v1/tx/mempool` ([#1810](#1810)) ([2d45b2e](2d45b2e))
* add `tx_count` property to `/extended/v2/blocks` ([#1778](#1778)) ([da4cd56](da4cd56))
* add dataset store ([4211328](4211328))
* add step to compile duckdb for Alpine image ([0f40e14](0f40e14))
* better handling of raw events insertion ([bb70ca9](bb70ca9))
* create `/extended/v2/burn-blocks/:height_or_hash/blocks` endpoint ([#1782](#1782)) ([20466a1](20466a1))
* disable rosetta via an ENV var ([#1804](#1804)) ([2d2aee3](2d2aee3))
* event-replay new_block events handling ([1708b42](1708b42))
* event-replay new_burn_block events handling ([6c0f448](6c0f448))
* event-replay raw events handling ([81f43cf](81f43cf))
* event-replay remainder events handling ([3ede07f](3ede07f))
* event-replay supporting parallel insertions ([f33ecee](f33ecee))
* events folder as environment var ([701bd1a](701bd1a))
* ingestion for `TenureChange` and `NakamotoCoinbase` tx types ([#1753](#1753)) ([7c45f53](7c45f53))
* parallel processing using node cluster ([d02a7e8](d02a7e8))
* pox-4 support ([#1754](#1754)) ([285806f](285806f))
* processing raw events in parallel ([7a6f241](7a6f241))
* support tenure_change in tx type filter queries ([#1808](#1808)) ([0831393](0831393))
* update to latest TenureChange tx payload ([#1767](#1767)) ([2afb65c](2afb65c))

### Bug Fixes

* add token offering ([8ef039e](8ef039e))
* allow contract-principals in `/extended/v1/address/:principal/mempool` endpoint [#1685](#1685) ([#1704](#1704)) ([163b76a](163b76a))
* better args handlling ([c77ac57](c77ac57))
* better path handling for workers ([1bd8f17](1bd8f17))
* changed processing order ([62a12bd](62a12bd))
* convert `chain_tip` materialized view into a table ([#1751](#1751)) ([04b71cc](04b71cc))
* do not load duckdb binary unless required ([#1776](#1776)) ([db859ae](db859ae))
* **docs:** URL query arrays should be formatted with `form` rather than comma-separated ([#1807](#1807)) ([e184fb5](e184fb5))
* flaky test ([484d2ea](484d2ea))
* flaky test ([65175f5](65175f5))
* handle `Problematic` status in `/drop_mempool_tx` event ([#1790](#1790)) ([ce9b38f](ce9b38f))
* import statement in replay controller ([7a10cd8](7a10cd8))
* insert block transaction data in batches ([#1760](#1760)) ([bf99e90](bf99e90))
* lint ([01589ea](01589ea))
* lint ([82eadcb](82eadcb))
* lint ([8c67ae5](8c67ae5))
* move `/extended/v1/burn_block` to `/extended/v2/burn-blocks` ([#1772](#1772)) ([bf2ef0a](bf2ef0a))
* on attachments_new events processing ([0707313](0707313))
* optimize mempool transaction reads and writes ([#1781](#1781)) ([3a02f57](3a02f57))
* re-enable indexes when finishing the replay ([fc379eb](fc379eb))
* remove dangling promise ([62a48ae](62a48ae))
* remove deprecated token endpoints ([#1775](#1775)) ([18f74b7](18f74b7))
* revert configurable DB index type ([86154b2](86154b2))
* support comma-separated strings in array query params ([#1809](#1809)) ([c9a4df8](c9a4df8))
* upgrade semver package to fix ReDoS vulnerability ([6b1605b](6b1605b))
* vercel preview builds ([#1783](#1783)) ([d36b1c2](d36b1c2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants