Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: should highlight that improvement only without local composer cache #196

Open
skonrad opened this issue May 10, 2019 · 6 comments
Open

Comments

@skonrad
Copy link

skonrad commented May 10, 2019

Note: The readme already states that the plugin speeds up the download of packages.

Though this fact should be pressed harder to ensure that ppl. who just fly over the description get the point that it only improves the download-speed (pre-fetches packages in parallel).
Was about to create an actual "issue" where there is none.

If the cache is already available (all packages available in composer-cache) the plugin does not give any improvements.
Though it would probably nice if it would actually override the installation-process and unpack the cached packages with multiple threads ;)

The advantage in my specific case is very limited as my cache is preserved and only purged on a monthly basis.

@hirak
Copy link
Owner

hirak commented May 10, 2019

What kind of sentences do you agree with?

@skonrad
Copy link
Author

skonrad commented May 10, 2019

Something in the vicinity of

Note that this plugin improves speed of package downloads only. It does not influence the speed of the installation process if all packages are available inside the local composer-cache.

maybe?

That would be more then sufficient in my eyes.

@vesper8
Copy link

vesper8 commented May 24, 2019

don't mean to derail here, but I'm just curious, if this package is as useful as I feel it is (been using it for 2 years+ now and see no reason to stop), why hasn't Composer implemented this functionality as part of the core Composer installer? o_O

@kubawerlos
Copy link
Contributor

@vesper8 it is already merged to Composer's 2.0 branch.

@danepowell
Copy link

Is it true that there's no benefit when packages are cached? The animated gif on the homepage (of the Laravel install) shows packages being loaded from cache, which seems somewhat deceptive if true. It also looks like the Composer plugin does other stuff (such as with dependency sorting) that might have performance implications even with cached packages.

@danepowell
Copy link

Ah... I just noticed that when Prestissimo is installed, Composer always claims packages are "loading from cache" even on a cold cache. That seems like its own point of confusion, but at least explains the discrepancy in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants