Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging a mountpoint to the Trash should unmount/eject #50

Closed
probonopd opened this issue Mar 8, 2021 · 2 comments
Closed

Dragging a mountpoint to the Trash should unmount/eject #50

probonopd opened this issue Mar 8, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@probonopd
Copy link
Member

Related to #41

Whenever the user tries to move a folder to the Trash, check whether something is mounted at that location(s), and ask the user whether that volume should be ejected/unmounted. In no case move a directory that has something mounted to it to the Trash!

What shall happen if a combination of files, folders and mountpoints is dragged by the user to the Trash? (What happens on a Mac in this case)?

@probonopd probonopd added the enhancement New feature or request label Mar 8, 2021
@probonopd
Copy link
Member Author

What shall happen if a combination of files, folders and mountpoints is dragged by the user to the Trash? (What happens on a Mac in this case)?

Dragging to the trash to eject

  • If one removable volume is dragged, the icon for the Trash changes to an Eject icon
  • If two or more removable item are dragged, the icon for the Trash changes to an Eject icon
  • If one or more removable volumes plus at least one non-removable volume are dragged, then the icon for the Trash does not change to an Eject icon on the Mac and dragging those to the Trash does not do anything
  • If one or more removable volumes plus at least one other object are dragged, then what is the right thing to do? (On the Mac, the icon for the Trash changes to an Eject icon but also will put the other object to the Trash which I find inconsistent)

Moving things to the Trash

  • If one or more file/folders are selected, the context menu has an item Move to Trash. I think we should also have it in the File menu for consistency
  • If one or more file/folders plus at least one other object (such as a Volume) are selected, there is no menu item Move to Trash

@probonopd probonopd pinned this issue Nov 22, 2022
@probonopd
Copy link
Member Author

Implemented in a simple form: If at least one of the items dragged to the trash is a mountpoint, then we try to unmount all dragged items. If someone wants to implement a more fancy form as described above, feel free to do it.

@probonopd probonopd unpinned this issue Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant