Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Convert_dtype on a list/tuple of many items is not performant #963

Open
3 tasks done
rly opened this issue Oct 6, 2023 · 0 comments
Open
3 tasks done

[Bug]: Convert_dtype on a list/tuple of many items is not performant #963

rly opened this issue Oct 6, 2023 · 0 comments
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)

Comments

@rly
Copy link
Contributor

rly commented Oct 6, 2023

What happened?

These lines convert each element of a list/tuple in a for loop. This could be more performant. Observed in Frank Lab conversions.

https://github.com/hdmf-dev/hdmf/blob/dev/src/hdmf/build/objectmapper.py#L234-L236

Steps to Reproduce

Write a timeseries where the timestamps are stored in a list of a million ints or floats.

Traceback

No response

Operating System

macOS

Python Executable

Conda

Python Version

3.11

Package Versions

No response

Code of Conduct
@rly rly added category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rly