Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: TermSet Restructure Part 3 #929

Closed
3 tasks done
mavaylon1 opened this issue Aug 1, 2023 · 1 comment
Closed
3 tasks done

[Feature]: TermSet Restructure Part 3 #929

mavaylon1 opened this issue Aug 1, 2023 · 1 comment
Assignees
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users

Comments

@mavaylon1
Copy link
Contributor

mavaylon1 commented Aug 1, 2023

What would you like to see added to HDMF?

Once part 1 and 2 are merged, adjustments may need to be made such that all containers for PyNWB pass this wrapper update along with adding the unwrapping functionality so that the wrapper does not interfere with write.

This may lead to adjustments to the BuildManager.

More details will follow after 1&2 have been developed.

Is your feature request related to a problem?

No response

What solution would you like?

Refer above

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@mavaylon1 mavaylon1 added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Aug 1, 2023
@mavaylon1 mavaylon1 self-assigned this Aug 1, 2023
@oruebel
Copy link
Contributor

oruebel commented Aug 2, 2023

This may lead to adjustments to the BuildManager.

The idea here is that the I/O backend does not need to know about TermSet's because this is only relevant for HERD files, which are written separately. So when creating builders for I/O we could simply "unwrap" the data so that nothing changes for the I/O backend.

Alternatively, the HDF5IO and ZarrIO backends would need to be updated to handle the case of wrapped datasets correctly.

adjustments may need to be made such that all containers for PyNWB pass this wrapper update

I would expect that the main issues here are likely: 1) passing docval (which should be a simple fix in HDMF), and 2) passing the various validation and data processing that the PyNWB classes want to do, e.g., when we check in __init__ that data values are correct or aligned with other fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

No branches or pull requests

2 participants