Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: TermSet Restructure (Stage 1): add from root_container #927

Closed
3 tasks done
mavaylon1 opened this issue Aug 1, 2023 · 1 comment
Closed
3 tasks done
Assignees
Labels
category: enhancement improvements of code or code behavior category: proposal proposed enhancements or new features priority: high impacts proper operation or use of feature important to most users

Comments

@mavaylon1
Copy link
Contributor

mavaylon1 commented Aug 1, 2023

What would you like to see added to HDMF?

This will be part 1 of restructuring TermSet to be more general by supporting validation for all "python attributes" of HDMF classes.

add_ref_termset will shift to take only a container object, in our case this will be a nwbfile but in HDMF this will be any container, and will find all children that have a TermSet (check for Data as instance) in order to bulk add to ExternalResources.

pseudo-code:

for containers in nwbfile.objects
... for attributes in containers
......<check>

Eventually this set up will be altered to not check for TermSet, but whether there is a TermSetWrapper class in place. This is defined in Part 2.

Is your feature request related to a problem?

No response

What solution would you like?

Refer above

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@mavaylon1 mavaylon1 self-assigned this Aug 1, 2023
@mavaylon1 mavaylon1 added category: enhancement improvements of code or code behavior category: proposal proposed enhancements or new features priority: high impacts proper operation or use of feature important to most users labels Aug 1, 2023
@mavaylon1
Copy link
Contributor Author

Note: Think about how termsets are used with compound data

@mavaylon1 mavaylon1 mentioned this issue Aug 8, 2023
11 tasks
@mavaylon1 mavaylon1 changed the title [Feature]: TermSet Restructure Part 1 [Feature]: TermSet Restructure add from root_container (Part 1) Aug 9, 2023
@mavaylon1 mavaylon1 changed the title [Feature]: TermSet Restructure add from root_container (Part 1) [Feature]: TermSet Restructure (Stage 1): add from root_container Aug 9, 2023
@mavaylon1 mavaylon1 added this to the Next Release milestone Aug 9, 2023
@rly rly removed this from the 3.14.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior category: proposal proposed enhancements or new features priority: high impacts proper operation or use of feature important to most users
Projects
None yet
Development

No branches or pull requests

2 participants