Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly group name to display group names with spaces #326

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

angcast
Copy link

@angcast angcast commented Dec 10, 2020

Previously, when a person tried to input a group name with spaces, it would not work. Now with this change, this is possible. If a person writes a name with spaces, the name attribute in the Group model will replace the spaces with underscores. Meanwhile, the friendly_name attribute will keep the spaces and use this to display the name with the spaces in the frontend.

@angcast angcast changed the title Created friendly group name Friendly group name to display group names with spaces Dec 10, 2020
@soyapark
Copy link
Member

Hi Angie!

I try to hit the "create" button and no matter if I have spaces or not I run into this following error from my web console.
image

[Error] TypeError: $("#group-name").val().replaceAll is not a function. (In '$("#group-name").val().replaceAll(' ','_')', '$("#group-name").val().replaceAll' is undefined)
	(anonymous function) (create_group.js:9)
	dispatch (jquery.min.js:3:8442)
	handle (jquery.min.js:3:5145)

@soyapark
Copy link
Member

Also, we might want to say in the interface that space is allowed?

Maximum 20 characters. Only alphanumeric characters, underscores, and dashes allowed.

.env.example Outdated
GMAIL_PASSWORD=YOUR_APP_PASSWORD

[email protected]
GMAIL_PASSWORD=ivuhzrgjsmaiyefg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you retract this change? .env.example is meant to be a template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants