Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor api into a module #70

Open
alexyao2015 opened this issue Jan 10, 2021 · 3 comments
Open

Refactor api into a module #70

alexyao2015 opened this issue Jan 10, 2021 · 3 comments
Labels
confirmed We know what should be done to resolve the issue enhancement New feature or request

Comments

@alexyao2015
Copy link
Member

Api.py is getting long due to all the API endpoints being grouped together into a single file. Perhaps convert it to a module instead with endpoints broken into separate files for Lights API, Groups API, etc., similar to how Hue documentation is setup.

@alexyao2015 alexyao2015 added the enhancement New feature or request label Jan 10, 2021
@marcelveldt
Copy link
Collaborator

This is possible (and very easy to do) but I don't think needed because most important the business logic needs to be moved out of the api intro controllers. See #71

If we do that and still think api.py is too large, we can chunk it up.

If you want me to, I can have a look at the controllers refactor next week. It's no rush but something we want to do if we do not want to go insane ;-)

@alexyao2015
Copy link
Member Author

Hmm yes. Let's work towards #71 first and see what the api.py file looks like after that. If needed, we can then revisit this after that is complete.

@alexyao2015 alexyao2015 added the confirmed We know what should be done to resolve the issue label Jan 11, 2021
@github-actions
Copy link
Contributor

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed We know what should be done to resolve the issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants