Question - refactoring to plug-ins

[alexnaspo]

Are there any pieces of functionality that are currently implemented in ghcide (or anywhere else) that should be moved to HLS plugins?

If so, I would love to contribute to any of these initiatives.

[jneira]

Hi, many thanks for willing to contribute to the repo.
The first one of pending refactors which come to my mind is the move of hlint tests to its plugin. Now they live in the main test component of hls:

haskell-language-server/test/functional/FunctionalCodeAction.hs

Line 40 in a800b9d

hlintTests :: TestTree

But it should be in the plugin package:

https://github.com/haskell/haskell-language-server/tree/master/plugins/hls-hlint-plugin

[alexnaspo]

I'll give this a shot

[alexnaspo]

What about moving the import completions into it's own plugin? I think I see a nice way of doing this. @jneira

[jneira]

sure, it sounds great but i would like to know the thoughts about from @pepeiborra

[pepeiborra]

I'm not particularly keen on this. The reason is that every completions plugin will incur an overhead in building the context and matching on it, leading to duplicate work as well as duplicate logic. In my opinion there are other areas of contribution with much higher impact.