From e35ae5c6b2cf31b46b808f64be2f12f485d1de17 Mon Sep 17 00:00:00 2001 From: Matthew Date: Fri, 4 Oct 2024 10:09:44 -0700 Subject: [PATCH] Fix owners memory leak --- internal/services/groups/group_resource.go | 2 +- internal/services/groups/group_resource_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/services/groups/group_resource.go b/internal/services/groups/group_resource.go index 36ec90672..4470e382b 100644 --- a/internal/services/groups/group_resource.go +++ b/internal/services/groups/group_resource.go @@ -1137,7 +1137,7 @@ func groupResourceUpdate(ctx context.Context, d *pluginsdk.ResourceData, meta in } existingOwners := make([]string, 0) - for resp.Model != nil { + if resp.Model != nil { for _, o := range *resp.Model { existingOwners = append(existingOwners, pointer.From(o.DirectoryObject().Id)) } diff --git a/internal/services/groups/group_resource_test.go b/internal/services/groups/group_resource_test.go index cee426c03..32f1f04ce 100644 --- a/internal/services/groups/group_resource_test.go +++ b/internal/services/groups/group_resource_test.go @@ -1021,7 +1021,7 @@ resource "azuread_application" "test" { resource "azuread_service_principal" "test" { count = 27 - application_id = azuread_application.test[count.index].application_id + client_id = azuread_application.test[count.index].client_id } resource "azuread_user" "test" {