Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

新的登录/注册页面会经过 TemplateHeadProcessor 处理 #6750

Closed
ruibaby opened this issue Oct 3, 2024 · 5 comments · Fixed by #6709
Closed

新的登录/注册页面会经过 TemplateHeadProcessor 处理 #6750

ruibaby opened this issue Oct 3, 2024 · 5 comments · Fixed by #6709
Labels
area/core Issues or PRs related to the Halo Core triage/needs-information Indicates an issue needs more information in order to work on it.
Milestone
2.20.0 LTS

Comments

@ruibaby
Copy link
Member

ruibaby commented Oct 3, 2024

系统信息

使用的哪种方式运行？

Source Code

发生了什么？

观察到目前新提供的登录相关的页面会经过 TemplateHeadProcessor 处理，注入了插件中提供的 head 标签代码，如图：

image

暂不确定是否会造成一定的隐患。

/area core
/triage needs-information

复现步骤

No response

相关日志输出

No response

附加信息

No response
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core triage/needs-information Indicates an issue needs more information in order to work on it. labels Oct 3, 2024
@JohnNiang
Copy link
Member

可以考虑过滤对登录、注册、找回密码、二步验证和登出模板的处理。

@ruibaby
Copy link
Member Author

ruibaby commented Oct 5, 2024

可以考虑过滤对登录、注册、找回密码、二步验证和登出模板的处理。

可以看看能不能专门为这些页面提供接口和代码注入设置项，毕竟这些页面还算比较特殊。

@ruibaby
Copy link
Member Author

ruibaby commented Oct 5, 2024

这个问题和 #6500 也有点相关。

@guqing guqing mentioned this issue Oct 9, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Oct 10, 2024
@guqing
refactor: head and footer tag injection to skip error pages (#6709)
02c5484 
#### What type of PR is this?
/kind improvement
/area core
/milestone 2.20.x

#### What this PR does / why we need it:
模板 head 和 footer 标签注入功能忽略错误页面避免当扩展发生错误时导致错误页面无法显示

#### Which issue(s) this PR fixes:
Fixes #6500 , #6750

#### Does this PR introduce a user-facing change?
```release-note
代码注入功能忽略对错误页面和登录注册等页面的注入
```
@JohnNiang
Copy link
Member

This issue was fixed by #6709.

/close

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 10, 2024

@JohnNiang: Closing this issue.

In response to this:

This issue was fixed by #6709.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot closed this as completed Oct 10, 2024
@JohnNiang JohnNiang added this to the 2.20.x milestone Oct 10, 2024
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/core Issues or PRs related to the Halo Core triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Milestone
2.20.0 LTS
Development

Successfully merging a pull request may close this issue.

refactor: head and footer tag injection to skip error pages guqing/halo
2 participants
@JohnNiang @ruibaby