Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or rename push-candidate command #65

Open
andreasabel opened this issue Oct 8, 2023 · 1 comment · May be fixed by #71
Open

Remove or rename push-candidate command #65

andreasabel opened this issue Oct 8, 2023 · 1 comment · May be fixed by #71
Milestone

Comments

@andreasabel
Copy link
Member

The hackage-cli command push-candidate is in the way of push-cabal when tab-completing hackage-cli push<TAB> or even hackage-cli push-ca<TAB>. Also, I never use it and I do not see what its purpose is when we have cabal upload.

I propose to remove it.

Alternatively, one could just move it into a legacy command group so that it is only available as hackage-cli legacy push-candidate.
Or rename it to candidate-push.

If you are a user of push-candidate, please leave a comment here how you use this feature and why it is important.
@hvr @phadej @gbaz @hesselink @bergmark @endgame @davean @Bodigrim @andreabedini @ulysses4ever @pbrisbin @sjakobi @vaibhavsagar

@andreabedini
Copy link

I don't use push-candidate but having candidate-push and push-cabal would look a bit funny to me (and triggers my OCD 😂).

Rename push-candidate to push-version-candidate? Maybe push/pull-cabal could also be push/pull-revision (matching the existing check-revision).

@andreasabel andreasabel added this to the 0.2 milestone Jan 26, 2024
andreasabel added a commit that referenced this issue Jan 26, 2024
Seems to just duplicate the functionality of `cabal upload`.

Closes #65.
@andreasabel andreasabel linked a pull request Jan 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants