Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the buffer size configurable #307

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make the buffer size configurable #307

wants to merge 2 commits into from

Conversation

ksolana
Copy link

@ksolana ksolana commented Oct 8, 2024

Fixes: #300

@ksolana
Copy link
Author

ksolana commented Oct 15, 2024

gentle ping in case anyone is around to review?

@gyscos
Copy link
Owner

gyscos commented Oct 15, 2024

Hi, and thanks for the work!

This looks reasonable, but you could already call with_output_buffer, right? This is just convenience to not create the Vec yourself?

@ksolana
Copy link
Author

ksolana commented Oct 15, 2024

Hi, and thanks for the work!

This looks reasonable, but you could already call with_output_buffer, right? This is just convenience to not create the Vec yourself?

That's true but it'll be great to have (a version of) new to this. Makes it easier to convince the users :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the buffer size configurable?
2 participants
@ksolana @gyscos