Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Notification Sound Plays Regardless of Runelite Global Settings #75

Open
celopez3 opened this issue Aug 17, 2024 · 1 comment
Open

Comments

@celopez3
Copy link

Describe the bug
The idle notification sound continues to play regardless of the Runelite application Global Notification Settings. I do not think a plugin should be able to ignore the core notification settings and other idle notifiers are able to respect the global notification settings.

To Reproduce
Steps to reproduce the behavior:

  1. While using the runelite-plugin-action-progress
  2. Click on Configuration -> search Runelite
  3. Scroll down to Notification Settings
  4. Turn off Sound, Volume, timeout, disable tray icons and notifications
  5. Fill inventory with chisel and gems, begin to chisel gems, and listen for notification sound which will play regardless of the notification settings within Runelite

Expected behavior
The sound should not play if the global settings have indicated that the user does not want notifications. This is actually a pretty annoying bug because nothing indicates where the sound is coming from so it's hard to even narrow down the issue to your app but it is reproducible

Screenshots
If applicable, add screenshots to help explain your problem.

@JonneSaloranta
Copy link

I think this is a Runelite issue. Runelite shouldn't allow notifications if they are turned off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants