-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Spacebar when Crafting Jewelry at Furnace doesn't show progress. #51
Comments
Noted. I will look into this next time I work on the plugin |
@guillaume009 Spacebar also not working to smith items most of the time for me. Happens whenever the action bar is not working. Progress bar also not working when this happens if I manually click to smith |
@1jacksonhall do you have more details? What items is it happening with? What do you mean that it happens when the action bar is not working? Isn't the action bar not working the result of the problem and not the source? It would be really odd if sometimes it work and sometime it doesn't for the same items |
@guillaume009 I was smithing addy items with bars. Had to disable this plugin and now I no longer get this issue. When its enabled spacebar hotkey does not work for me most of the time (seems random). I was trying to smith my last smithed item with the smithing gui on my screen |
even without spacebar it doesnt show the bar for Jewelry for me. (so both preselected with spacebar and solo with you yourself selecting the one with a mouse click) |
@l3vines what item exactly? |
Was doing jade amulets to make the herblore amulets |
Working on a fix |
+1 to this.
|
@npollender do you mean that sometimes on the smithing interface if you click it works, whereas others even clicking doesn't do anything? |
The interface clicking should work correctly but when using spacebar, it doesn't work since it's not implemented. I've got a draft pr for fixing this issue |
@guillaume009 Clicking always works, space bar seems to only work sometimes (and no progress bar when it actually does work). |
Two things are being mixed here. JonneSaloranta is talking about jewelry and npollender about smithing. This should address the part that make the plugin prevent the spacebar from working with smithing. I doubt, however, that it will make the spacebar show the progress bar every time |
Oops, my bad. Anyway, when i was taking a look at the original issue, i came across the smithing issue too. |
Those errors should be tackled already here If you see more still, of course, you are welcome to investigate them |
Describe the bug
Crafting Jewelry at a furnace does not show action progress if using spacebar to begin the action. Manually clicking the jewelry still shows the progress bar as normal.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Using spacebar should show the progress the same as manually clicking on the item in the crafting window.
The text was updated successfully, but these errors were encountered: