Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Spacebar when Crafting Jewelry at Furnace doesn't show progress. #51

Open
SirGarde opened this issue Mar 11, 2024 · 15 comments
Open

Comments

@SirGarde
Copy link

Describe the bug
Crafting Jewelry at a furnace does not show action progress if using spacebar to begin the action. Manually clicking the jewelry still shows the progress bar as normal.

To Reproduce
Steps to reproduce the behavior:

  • Jewelry mould + gold bars in inventory
  • Find Furnace
  • Have a pre-selected crafting option
  • press spacebar to begin crafting

Expected behavior
Using spacebar should show the progress the same as manually clicking on the item in the crafting window.

@guillaume009
Copy link
Owner

Noted. I will look into this next time I work on the plugin

@1jacksonhall
Copy link

@guillaume009 Spacebar also not working to smith items most of the time for me. Happens whenever the action bar is not working. Progress bar also not working when this happens if I manually click to smith

@guillaume009
Copy link
Owner

@1jacksonhall do you have more details? What items is it happening with? What do you mean that it happens when the action bar is not working? Isn't the action bar not working the result of the problem and not the source?

It would be really odd if sometimes it work and sometime it doesn't for the same items

@1jacksonhall
Copy link

@guillaume009 I was smithing addy items with bars. Had to disable this plugin and now I no longer get this issue. When its enabled spacebar hotkey does not work for me most of the time (seems random). I was trying to smith my last smithed item with the smithing gui on my screen

@l3vines
Copy link

l3vines commented Aug 13, 2024

even without spacebar it doesnt show the bar for Jewelry for me. (so both preselected with spacebar and solo with you yourself selecting the one with a mouse click)

@guillaume009
Copy link
Owner

@l3vines what item exactly?

@l3vines
Copy link

l3vines commented Aug 14, 2024

@l3vines what item exactly?

Was doing jade amulets to make the herblore amulets

@JonneSaloranta
Copy link

Working on a fix

@npollender
Copy link

+1 to this.
Behaviour I've encountered:

  • Space bar doesn't work on smithing interface, have to manually click item instead. Progress bar appears.
  • Space bar does work on smithing interface, progress bar does not appear.

@guillaume009
Copy link
Owner

@npollender do you mean that sometimes on the smithing interface if you click it works, whereas others even clicking doesn't do anything?

@JonneSaloranta
Copy link

The interface clicking should work correctly but when using spacebar, it doesn't work since it's not implemented.

I've got a draft pr for fixing this issue

@npollender
Copy link

@guillaume009 Clicking always works, space bar seems to only work sometimes (and no progress bar when it actually does work).

@guillaume009
Copy link
Owner

Two things are being mixed here. JonneSaloranta is talking about jewelry and npollender about smithing.

#81

This should address the part that make the plugin prevent the spacebar from working with smithing. I doubt, however, that it will make the spacebar show the progress bar every time

@JonneSaloranta
Copy link

Oops, my bad.

Anyway, when i was taking a look at the original issue, i came across the smithing issue too.
was printing error stacktrace for something. will prob take a look again.

@guillaume009
Copy link
Owner

Those errors should be tackled already here

runelite/plugin-hub#6743

If you see more still, of course, you are welcome to investigate them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants