Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing links from browser to Zim wiki notes #2409

Closed
4 tasks done
Self-Perfection opened this issue Sep 5, 2024 · 2 comments · Fixed by #2377
Closed
4 tasks done

Sharing links from browser to Zim wiki notes #2409

Self-Perfection opened this issue Sep 5, 2024 · 2 comments · Fixed by #2377

Comments

@Self-Perfection
Copy link
Contributor

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

Shared links from web browser are lost.

Steps to reproduce

  1. Open https://news.ycombinator.com/item?id=35618503 in browser
  2. Share link to Markor
  3. Do not edit proposed text and choose one of existing Zim wiki notes

For a long you would get

----
[Lightweight SQLite Editor for Windows / Hacker News](https://news.ycombinator.com/item?id=35618503 )

This is not a Zim wiki syntax but is generally acceptable. A couple of month ago there were a regression and now I get

----
[[LINK|TITLE]]

All shared information is lost!
The best result would be get a link in Zim format:

[[https://news.ycombinator.com/item?id=35618503|Lightweight SQLite Editor for Windows / Hacker News]]

but actually I would be happy if sharing will retain actual title and URL regardless of format.

Information

Android version: CalyxOS 14
Device: Irrelevant
App Version: 2.12.5

Source

F-Droid

Format / File type

Wikitext, Zim

Additional info / Log

-
@harshad1
Copy link
Collaborator

harshad1 commented Sep 6, 2024

This is a bug. I will fix it.

@harshad1
Copy link
Collaborator

Solved in #2377

@gsantner gsantner linked a pull request Sep 16, 2024 that will close this issue
Navigation and highlighting improvements #2377
Merged
2 tasks
elyahw pushed a commit to writing-tools/marelias-notepad that referenced this issue Sep 26, 2024
@harshad1 @elyahw
Navigation and highlighting improvements (PR gsantner#2377 closes gsa…
00f64e4 
…ntner#2409 closes gsantner#2410)

* Many fixes to navigation and go back
* Cleanups to fragment handling
* Tweaks to showing keyboard
* Final tweaks to activity stacks
* Removed unnecessary 'synchronized' calls for perf
* Tweaks to highlighting
* Reverted some highlighting changes
* Fix template cursor start
* Improvements to display of file browser dialog / fragment
* Initial set of changes for async
* Using canonical paths and and static members
* Defensive logic for indices
* Batching fixup for reduced computation
* Switching back to start end as it made no difference
* Tweaks to launching; file paths -> canonical
* Fixed wikitext link formatting

(cherry picked from commit c5fe529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Navigation and highlighting improvements harshad1/markor
2 participants
@harshad1 @Self-Perfection